summaryrefslogtreecommitdiffstats
path: root/src/eulogium.c
diff options
context:
space:
mode:
authorOlliver Schinagl <o.schinagl@ultimaker.com>2015-06-19 05:38:09 (GMT)
committerOlliver Schinagl <o.schinagl@ultimaker.com>2015-06-19 05:38:09 (GMT)
commit9c5ba21b67e04cbd981c784abb3455b7358dbf48 (patch)
tree1f319b3c2f39768d74b3df7c09b49d11f1686730 /src/eulogium.c
parent7f2e8b1b3e5c80a939f3fcf478fb89a7731910fd (diff)
downloadeulogium-9c5ba21b67e04cbd981c784abb3455b7358dbf48.zip
eulogium-9c5ba21b67e04cbd981c784abb3455b7358dbf48.tar.gz
eulogium-9c5ba21b67e04cbd981c784abb3455b7358dbf48.tar.bz2
add some todo reminders
Signed-off-by: Olliver Schinagl <o.schinagl@ultimaker.com>
Diffstat (limited to 'src/eulogium.c')
-rw-r--r--src/eulogium.c6
1 files changed, 3 insertions, 3 deletions
diff --git a/src/eulogium.c b/src/eulogium.c
index 60bc75c..5485719 100644
--- a/src/eulogium.c
+++ b/src/eulogium.c
@@ -1418,7 +1418,7 @@ static void menu_usb_storage(struct eulogium_data *eulogium)
uint_fast16_t mount_len;
/* Only care about last entry. Yes this is wrong as we need a UI element to handle this properly first. XXX */
- mount = eina_list_data_get(eina_list_last(eulogium->mounts));
+ mount = eina_list_data_get(eina_list_last(eulogium->mounts)); /* XXX double check if we don't need ** here */
if (!mount)
return;
@@ -2184,7 +2184,7 @@ static void _cb_select_file(void *data, Evas_Object *obj EINA_UNUSED, void *even
new_dir_len = strlen(filepath) + 1;
new_dir = malloc(sizeof(struct menu_def)); /* XXX memleak, free on pop */
- new_dir->title = "asdf";
+ new_dir->title = "TODO!"; /* TODO */
new_dir->type = LIST_FILE;
new_dir->dir.path = malloc(new_dir_len); /* XXX memleak, but by copying we can free _filelist_data without worry */
strncpy(new_dir->dir.path, filepath, new_dir_len);
@@ -3125,7 +3125,7 @@ static void _on_unit_removed_ret(void *data, const Eldbus_Message *msg)
return;
}
EINA_LOG_ERR("Medium remove request (%s)", id);
- list = eina_list_search_unsorted_list(eulogium->mounts, _mount_find_cb, id);
+ list = eina_list_search_unsorted_list(eulogium->mounts, _mount_find_cb, id); /* XXX verify if we don't need a pointer pointer for mounts */
mount = eina_list_data_get(list);
if (!mount) {
EINA_LOG_CRIT("Mount %s is NULL, this should not happen!", id);